fix: time.Since should not be used in defer statement #2014
+17
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
druzn3k
force-pushed
the
fix/make-vet-happy-with-time-since-deferring
branch
from
5368ded to
f5dbf5b
Compare
|
@druzn3k: maybe adding a |
Why not :) I'm thinking about something in this ballpark: func (c *immuClient) debugWithTimeElapsed(msg string, start time.Time)The name is on the ugly side though, but I can't come up with something better on the spot. Suggestions? |
|
maybe: func (c *immuClient) debugElapsedTime(method string, start *time.Time)You could just pass the method name |
druzn3k
force-pushed
the
fix/make-vet-happy-with-time-since-deferring
branch
from
f5dbf5b to
b9dffb0
Compare
|
done @ostafen . Let me know if you like this version better. |
This commit fixes the complaining from `go vet` about the deferring of `time.Since`. This can cause wrong time evaluation of the elapsed time. This impact only the debug level, but still it should be addressed. To make the code a little bit more readable, I wrote a method on the `immuClient` instance with the signature `debugElapsedTime(method string, start time.Time)`. ref: golang/go#60048 Signed-off-by: Maurizio Del Corno <[email protected]>
druzn3k
force-pushed
the
fix/make-vet-happy-with-time-since-deferring
branch
from
b9dffb0 to
8a24740
Compare
ostafen
approved these changes
Aug 21, 2024
|
@druzn3k: looks good to me, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the complaining from
go vetabout the deferring oftime.Since. This can cause wrong time evaluation of the elapsed time. This impact only the debug level, but still it should be addressed.ref: golang/go#60048
Signed-off-by: Maurizio Del Corno [email protected]